Re: [PATCH v2 02/12] vkms: properly compute gamma LUT size in vkms_atomic_check()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/vkms: missing Fixes trailer for LUT size fix in
  vkms_atomic_check()
--

commit ce5b5586969b38a36fc2d39e5403ee7e86059811
Author: Leandro Ribeiro <leandro.ribeiro@collabora.com>

> vkms: properly compute gamma LUT size in vkms_atomic_check()
>
> Gamma LUT size is being computed wrongly, dividing blob size by
> sizeof(struct drm_color_lut *). But the blob is an array of struct
> drm_color_lut.
>
> Replace sizeof(struct drm_color_lut *) with sizeof(struct
> drm_color_lut), properly validating the userspace gamma LUT size.
>
> Issue caught by Sashiko bot:
> https://sashiko.dev/#/patchset/20260804203351.148521-1-leandro.ribeiro@collabora.com?part=1
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Reviewed-by: Robert Mader <robert.mader@collabora.com>
> Tested-by: Robert Mader <robert.mader@collabora.com>
> Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>

[Severity: Low]
Since this fixes the gamma LUT size check in vkms_atomic_check(), which
rejected valid 129-to-256-entry LUTs on 32-bit architectures where
sizeof(struct drm_color_lut *) is 4 bytes instead of 8, should the commit
message include:

  Fixes: db1f254f2cfa ("drm/vkms: Add support to 1D gamma LUT")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106201813.129911-1-leandro.ribeiro@collabora.com?part=2