Re: [PATCH v3 23/23] s390: Report AEF features to sysfs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] s390: missing static const on bin_attr_qmc and
  bin_attr_save_area
--

commit 2934d9947793e4c4621a99293c7dadc5c2b8442b
Author: Steffen Eiden <seiden@linux.ibm.com>

s390: Report AEF features to sysfs

This commit exposes Arm Execution Facility (AEF) capabilities, supported
formats, vCPU limits, and raw QAAF query blocks to userspace under
/sys/firmware/aef/ and documents the new sysfs ABI.

> diff --git a/arch/s390/kernel/aef.c b/arch/s390/kernel/aef.c
> index 31e18953d7b31..96a6d63b26950 100644
> --- a/arch/s390/kernel/aef.c
> +++ b/arch/s390/kernel/aef.c

[ ... ]

> @@ -38,6 +47,68 @@ bool aef_usable(void)

[ ... ]

> +static ssize_t qmc_read(struct file *filp, struct kobject *kobj,
> +			const struct bin_attribute *attr, char *buf, loff_t off,
> +			size_t count)
> +{
> +	return memory_read_from_buffer(buf, count, &off, &qmc, sizeof(qmc));
> +}
> +
> +BIN_ATTR_RO(qmc, sizeof(qmc));
> +
> +static ssize_t save_area_read(struct file *filp, struct kobject *kobj,
> +			      const struct bin_attribute *attr, char *buf,
> +			      loff_t off, size_t count)
> +{
> +	return memory_read_from_buffer(buf, count, &off, &save_area,
> +				       sizeof(save_area));
> +}
> +
> +BIN_ATTR_RO(save_area, sizeof(save_area));

[Severity: Low]
Should BIN_ATTR_RO(qmc, ...) and BIN_ATTR_RO(save_area, ...) be marked static
const?  BIN_ATTR_RO() expands without storage qualifiers, so omitting static
const exports bin_attr_qmc and bin_attr_save_area as mutable global symbols
in .data and triggers sparse -Wdecl warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106-sysreg-v3-0-75e95980fb10@linux.ibm.com?part=23