From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH 1/1] rapidio/tsi721: move dma_device from rio_mport to tsi721_device
Date: Fri, 06 Nov 2026 21:50:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-202299@kernel.org> (raw)
In-Reply-To: <20261106214132.4172049-1-Frank.Li@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] rapidio/tsi721: build failure in struct tsi721_device when
CONFIG_RAPIDIO_DMA_ENGINE=n
--
commit 39ba91a98facae7b37c8dcc0ceb0e150ad9bee9a
Author: Frank Li <Frank.Li@nxp.com>
rapidio/tsi721: move dma_device from rio_mport to tsi721_device
This commit moves the embedded struct dma_device from struct rio_mport into
struct tsi721_device and replaces the mport member with a pointer.
> diff --git a/drivers/rapidio/devices/tsi721.h b/drivers/rapidio/devices/tsi721.h
> index 4f996ce627254..2df3955581af3 100644
> --- a/drivers/rapidio/devices/tsi721.h
> +++ b/drivers/rapidio/devices/tsi721.h
> @@ -886,6 +886,7 @@ struct tsi721_device {
> u32 pw_discard_count;
>
> /* BDMA Engine */
> + struct dma_device dma;
> struct tsi721_bdma_maint mdma; /* Maintenance rd/wr request channel */
>
> #ifdef CONFIG_RAPIDIO_DMA_ENGINE
[Severity: Medium]
Does embedding struct dma_device dma outside the #ifdef
CONFIG_RAPIDIO_DMA_ENGINE block break the build when
CONFIG_RAPIDIO_DMA_ENGINE is disabled?
include/linux/rio.h only includes linux/dmaengine.h when
CONFIG_RAPIDIO_DMA_ENGINE is enabled, and neither tsi721.c nor tsi721.h
includes it directly, so compiling drivers/rapidio/devices/tsi721.c fails
with an incomplete type error for field dma.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106214132.4172049-1-Frank.Li@oss.nxp.com?part=1
prev parent reply other threads:[~2026-11-06 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 21:41 [PATCH 1/1] rapidio/tsi721: move dma_device from rio_mport to tsi721_device Frank.Li
2026-11-06 21:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202299@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.