Re: [PATCH v5 2/2] rust: serio: add serio bus abstractions and port Gravis Stinger driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] rust: serio: invalid irqreturn constructor call in
  interrupt_callback()
--

commit 80f5c0b2557c72b097feba2779e0c1b32a6bd3c7
Author: clicedvly768 <harepro29@gmail.com>

rust: serio: add serio bus abstractions and port Gravis Stinger driver

This commit adds Rust abstractions for the serio bus subsystem and ports
the Gravis Stinger serial gamepad driver to Rust.

> diff --git a/rust/kernel/serio.rs b/rust/kernel/serio.rs
> new file mode 100644
> index 0000000000000..aca0b5a4f8742
> --- /dev/null
> +++ b/rust/kernel/serio.rs

[ ... ]

> +    unsafe extern "C" fn interrupt_callback(
> +        serio: *mut bindings::serio,
> +        data: c_uchar,
> +        flags: c_uint,
> +    ) -> bindings::irqreturn_t {
> +        // SAFETY: `serio` is valid.
> +        let raw = unsafe { bindings::serio_get_drvdata(serio) };
> +        if raw.is_null() {
> +            return bindings::irqreturn(IrqReturn::None as u32);
> +        }
> +
> +        // SAFETY: `raw` was created via `into_foreign()` in `connect_callback`.
> +        let mut borrowed = unsafe { <T::Data as ForeignOwnable>::borrow_mut(raw) };
> +        let ret = T::interrupt(&mut borrowed, data, flags);
> +        bindings::irqreturn(ret as u32)
> +    }

[Severity: High]
Does calling bindings::irqreturn(...) as a tuple-struct constructor break
the build when CONFIG_SERIO=y and CONFIG_RUST=y are enabled?

bindgen emits bindings::irqreturn and bindings::irqreturn_t as type aliases
for ffi::c_uint rather than a newtype struct, so invoking bindings::irqreturn
with function call syntax fails to compile with E0423.  Casting the values
with "as bindings::irqreturn_t" avoids this.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106223033.452853-1-harepro29@gmail.com?part=2