Re: [PATCH v5 2/2] usb: misc: onboard_usb_dev: don't defer probing after the device is configured

[sashiko-bot@kernel.org]

> onboard_usb_dev breaks the rule that a driver must not return
> -EPROBE_DEFER from its probe after it has registered child devices (see
> commit fbc35b45f9f6 ("Add documentation on meaning of -EPROBE_DEFER")).
> Its USB device driver sets generic_subclass, so the generic probe runs
> first and registers the device's interfaces. onboard_dev_usbdev_probe()
> then returns -EPROBE_DEFER until the platform device for the onboard
> device has probed. On the BeagleY-AI, this results in a probe loop,
> which has broken booting since commit f918e3804498 ("arm64: enable
> HAVE_SHARED_GPIOS for all ARM64 platforms").
> 
> Call the generic driver's operations from the driver itself instead of
> relying on generic_subclass, so that the probe is deferred before the
> device is configured. The device now stays unconfigured while the probe
> is deferred, including when the platform device never probes. Before, it
> was configured and unconfigured repeatedly until the platform device
> probed.
> 
> Make onboard_dev_usbdev_match() not match a device when neither its
> node nor its peer hub's node has a platform device, so that the generic
> driver binds it instead. If the platform device goes away between match
> and probe, return -ENODEV instead of -EINVAL, so that usb_probe_device()
> falls back to the generic driver.
> 
> Fixes: 8bc063641ceb ("usb: misc: Add onboard_usb_hub driver")
> Suggested-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: James Clark <jjc@jclark.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794018128.git.jjc@jclark.com?part=2