Re: [PATCH] arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: sm8750: missing Fixes trailer for commit
  be9d54c35312
--

commit 3e2d2cedc67ebfc939a205a1181e0f73888ada0d
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>

> arm64: dts: qcom: sm8750: mark the ADSP fastrpc node as non-secure domain
>
> On SM8750 the ADSP fastrpc instance used by the sensor core (and by the
> other non-secure ADSP users) is the one the firmware exposes as
> non-secure; the CDSP fastrpc node already carries
> "qcom,non-secure-domain", the ADSP one does not.  With the fastrpc driver
> keying the secure/non-secure split off that property, the ADSP only
> instantiates /dev/fastrpc-adsp-secure and userspace never gets
> /dev/fastrpc-adsp, so libssc/hexagonrpcd cannot attach to the sensor PD
> (qrtr service 400) and iio-sensor-proxy reports no sensors at all.
>
> Observed on the Lenovo Legion Tab Y700 Gen4 (TB322FC), which is SM8750
> based: without this property /dev/fastrpc-adsp never appears and
> iio-sensor-proxy exposes neither accelerometer, ambient light nor
> proximity; with it, qrtr shows the "Snapdragon Sensor Core service"
> (id 400) and all three sensor types report as available.  The change is
> one property on one node, matching what the CDSP node already does.
>
> Tested with `make CHECK_DTBS=y qcom/sm8750-mtp.dtb` (no new warnings; the
> single avoid_unnecessary_addr_size warning on dsi@ae96000 is present
> before and after).
>
> *** AI-assistance disclosure ***
> This patch and its commit message were prepared with the help of an LLM
> coding assistant.  The author reviewed the change line by line, ran the
> checks quoted above on his own hardware and takes full responsibility
> for the content.
>
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>

[Severity: Low]
Since this fixes the ADSP fastrpc node added in be9d54c35312 ("arm64: dts:
qcom: sm8750: add ADSP fastrpc-compute-cb nodes"), should this include:

  Fixes: be9d54c35312 ("arm64: dts: qcom: sm8750: add ADSP fastrpc-compute-cb nodes")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107032646.32363-1-xiaqinghuan@mail.ustc.edu.cn?part=1