From: sashiko-bot@kernel.org
To: mdshahid03@gmail.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: Fix NULL pointer dereference in memory cleanup
Date: Sat, 07 Nov 2026 09:43:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-202780@kernel.org> (raw)
In-Reply-To: <20261107093611.42311-1-mdshahid03@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scsi: be2iscsi: missing Fixes trailer in commit message for
beiscsi_alloc_mem()
--
commit 3a59c9fd50bd58745d465b3451671b988442c55a
Author: Mohammad Shahid <mdshahid03@gmail.com>
> scsi: be2iscsi: Fix NULL pointer dereference in memory cleanup
>
> During memory allocation ,DMA memory may be allocated successfully
> before the descriptor array allocation fails.
>
> In this case ,mem_descr->mem_array is NULL,but cleanup path tries
> to access it.
>
> Use mem_arr_orig to free the DMA allocation of the current
> descriptor and handle previously allocated descriptors separately.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
[Severity: Low]
Since this fixes the error cleanup loop in beiscsi_alloc_mem() from the
initial driver commit, should the commit message include:
Fixes: 6733b39a1301 ("[SCSI] be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107093611.42311-1-mdshahid03@gmail.com?part=1
prev parent reply other threads:[~2026-11-07 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 9:36 [PATCH] scsi: be2iscsi: Fix NULL pointer dereference in memory cleanup mdshahid03
2026-11-07 9:43 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202780@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.