From: sashiko-bot@kernel.org
To: "Myria Sarvay" <myrialsarvay@gmail.com>
Cc: linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 02/15] drivers/perf: apple_m1: Remove unused variables
Date: Sat, 07 Nov 2026 10:54:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-202829@kernel.org> (raw)
In-Reply-To: <20261107-m3-plus-pmu-events-v2-2-acf1e78da039@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drivers/perf: apple_m1: wrong Fixes commit for
m1_pmu_enable_event()
--
commit 46e6058673421fd04a6bec454dd88350e27b9540
Author: Myria Sarvay <myrialsarvay@gmail.com>
> drivers/perf: apple_m1: Remove unused variables
>
> These variables are calculated elsewhere as well, remove the extra dead
> code.
>
> Signed-off-by: Myria Sarvay <myrialsarvay@gmail.com>
> Fixes: a639027a1be1 ("drivers/perf: Add Apple icestorm/firestorm CPU PMU driver")
[Severity: Low]
In commit a639027a1be1 ("drivers/perf: Add Apple icestorm/firestorm CPU PMU
driver"), m1_pmu_enable_event() passed evt, user, and kernel to
m1_pmu_configure_counter(). Commit 75ecffc361bb ("drivers/perf: apple_m1:
Refactor event select/filter configuration") changed
m1_pmu_configure_counter() to take event->hw.config_base directly, leaving
those local variables unused.
Should the Fixes tag reference 75ecffc361bb ("drivers/perf: apple_m1:
Refactor event select/filter configuration") instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-m3-plus-pmu-events-v2-0-acf1e78da039@gmail.com?part=2
next prev parent reply other threads:[~2026-11-07 10:54 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 10:48 [PATCH v2 00/15] drivers/perf: apple_m1: Add M3/M4/A18 Pro Support Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:48 ` [PATCH v2 01/15] dt-bindings: arm: pmu: Add Apple M3/M4/A18 Pro SoC CPU PMU compatibles Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:52 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 02/15] drivers/perf: apple_m1: Remove unused variables Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:54 ` sashiko-bot [this message]
2026-11-07 10:48 ` [PATCH v2 03/15] drivers/perf: apple_m1: Support per-implementation event tables Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:53 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 04/15] drivers/perf: apple_m1: Support per-implementation event size Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:53 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 05/15] drivers/perf: apple_m1: Use macros for per-implementation init functions Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:52 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 06/15] drivers/perf: apple_m1: Add Apple M3 Series Support Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:53 ` sashiko-bot
2026-11-08 0:42 ` kernel test robot
2026-11-07 10:48 ` [PATCH v2 07/15] drivers/perf: apple_m1: Add Apple M4 " Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:55 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 08/15] drivers/perf: apple_m1: Add Apple A18 Support Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:53 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 09/15] arm64: dts: apple: t603*: Add core interrupt affinities Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:53 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 10/15] arm64: dts: apple: t8140: " Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:57 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 11/15] arm64: dts: apple: t603x: Add PMU Device Nodes Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:55 ` sashiko-bot
2026-11-07 10:48 ` [PATCH v2 12/15] arm64: dts: apple: t8122: " Myria Sarvay via B4 Relay
2026-11-07 10:48 ` Myria Sarvay
2026-11-07 10:54 ` sashiko-bot
2026-11-07 10:49 ` [PATCH v2 13/15] arm64: dts: apple: t604x: " Myria Sarvay via B4 Relay
2026-11-07 10:49 ` Myria Sarvay
2026-11-07 10:55 ` sashiko-bot
2026-11-07 10:49 ` [PATCH v2 14/15] arm64: dts: apple: t8132: " Myria Sarvay via B4 Relay
2026-11-07 10:49 ` Myria Sarvay
2026-11-07 10:56 ` sashiko-bot
2026-11-07 10:49 ` [PATCH v2 15/15] arm64: dts: apple: t8140: " Myria Sarvay via B4 Relay
2026-11-07 10:49 ` Myria Sarvay
2026-11-07 10:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202829@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=myrialsarvay@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.