From: sashiko-bot@kernel.org
To: "Tomasz Bojanowski" <tomasz@bojanowski.me>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6683) Remove the 32 mV voltage scale
Date: Sat, 07 Nov 2026 15:09:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-202986@kernel.org> (raw)
In-Reply-To: <20261107150619.297999-1-tomasz@bojanowski.me>
> in_from_reg() is meant to scale the VCC, VSB, AVSB and VBAT sources
> by 32 mV, but show_in_reg() passes it the monitor channel of the first
> three voltage sensors instead of the source of the sensor shown. The
> 32 mV case therefore never matches, and all voltages have been scaled
> by 16 mV since commit 41082d66bfd6 ("hwmon: Driver for NCT6683D").
>
> According to the datasheet, there is no 32 mV LSB. On an MSI MAG
> B850M MORTAR WIFI (NCT6687D, customer ID 0x20d), VCC reads 3.31 V,
> VSB and AVSB 3.34 V and VBAT 3.10 V with 16 mV. With 32 mV they would
> read 6.6 V, 6.7 V and 6.2 V.
>
> Drop the source argument and the 32 mV case. No functional change.
>
> Link: https://lore.kernel.org/linux-hwmon/20261106144247.30507-1-tomasz@bojanowski.me/
> Signed-off-by: Tomasz Bojanowski <tomasz@bojanowski.me>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107150619.297999-1-tomasz@bojanowski.me?part=1
next prev parent reply other threads:[~2026-11-07 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 15:06 [PATCH] hwmon: (nct6683) Remove the 32 mV voltage scale Tomasz Bojanowski
2026-11-07 15:09 ` sashiko-bot [this message]
2026-11-07 16:28 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202986@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tomasz@bojanowski.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.