Re: [PATCH v11 2/2] rust: serio: add serio bus abstractions and port Gravis Stinger driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] rust: serio: invalid irqreturn constants in
  Registration::interrupt_callback()
--

commit f585fad088f2bb569ece89cb8cd21210ef843ac9
Author: Vecheslav Filatov <harepro29@gmail.com>

rust: serio: add serio bus abstractions and port Gravis Stinger driver

This commit adds Rust abstractions for the serio bus subsystem and ports
the Gravis Stinger serial gamepad driver to Rust.

> diff --git a/rust/kernel/serio.rs b/rust/kernel/serio.rs
> new file mode 100644
> index 0000000000000..add6dc47bdbf3
> --- /dev/null
> +++ b/rust/kernel/serio.rs
> @@ -0,0 +1,331 @@

[ ... ]

> +    unsafe extern "C" fn interrupt_callback(
> +        serio: *mut bindings::serio,
> +        data: c_uchar,
> +        flags: c_uint,
> +    ) -> bindings::irqreturn_t {
> +        // SAFETY: `serio` is valid.
> +        let raw = unsafe { bindings::serio_get_drvdata(serio) };
> +        if raw.is_null() {
> +            return bindings::irqreturn::IRQ_NONE;
> +        }
> +
> +        // SAFETY: `raw` was created via `into_foreign()` in `connect_callback`.
> +        let mut borrowed = unsafe { <T::Data as ForeignOwnable>::borrow_mut(raw) };
> +        match T::interrupt(&mut borrowed, data, flags) {
> +            IrqReturn::None => bindings::irqreturn::IRQ_NONE,
> +            IrqReturn::Handled => bindings::irqreturn::IRQ_HANDLED,
> +        }
> +    }

[Severity: High]
Does Registration::interrupt_callback() fail to compile when CONFIG_RUST=y
and CONFIG_SERIO=y?  bindgen generates bindings::irqreturn as a type alias
for ffi::c_uint with top-level constants bindings::irqreturn_IRQ_NONE and
bindings::irqreturn_IRQ_HANDLED (as used in rust/kernel/irq/request.rs),
so bindings::irqreturn::IRQ_NONE and bindings::irqreturn::IRQ_HANDLED do
not exist.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107151238.607451-1-harepro29@gmail.com?part=2