Re: [PATCH v2 2/3] scsi: lpfc: Report bsg mailbox failures as an errno

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] scsi: lpfc: missing Fixes trailer for commit 7a4702774381
--

commit 7d6fb8accad0321798579f3066c01e672f56703a
Author: Wentao Liang <vulab@iscas.ac.cn>

> scsi: lpfc: Report bsg mailbox failures as an errno
>
> lpfc_bsg_issue_mbox() hands a command to the port with MBX_NOWAIT and, if
> that does not start the command, returns the raw result to
> lpfc_bsg_mbox_cmd(), which stores it in the bsg reply.  bsg-lib only
> reports a negative result as an error to the ioctl caller, so a positive
> MBX status such as MBX_NOT_FINISHED is passed off as success, with
> device_status holding the low byte of the status and no reply data.
>
> Report -EIO instead, as the polled path in the same function already maps
> its failures to -ETIME and -ENODEV.
>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

[Severity: Low]
7a4702774381 ("[SCSI] lpfc 8.3.11: Driver management improvements via BSG")
dropped the -EIO assignment when refactoring lpfc_bsg_issue_mbox() to use
the job_done label.  Should this include:

  Fixes: 7a4702774381 ("[SCSI] lpfc 8.3.11: Driver management improvements via BSG")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107161655.2628796-1-vulab@iscas.ac.cn?part=2