From: sashiko-bot@kernel.org
To: "Chengyu Liu" <lui2012qwq@gmail.com>, linux-raid@vger.kernel.org
Cc: yukuai@fygo.io
Subject: Re: [PATCH] md/bitmap: fix missing_pages restore in resize rollback
Date: Sat, 07 Nov 2026 16:53:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-203076@kernel.org> (raw)
In-Reply-To: <20261107164305.11476-1-lui2012qwq@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] md/bitmap: missing Fixes trailer for commit c9d650322829
--
commit 5db0c6c47a033569a681ebcef85c2c4ea4329e98
Author: Chengyu Liu <lui2012qwq@gmail.com>
> md/bitmap: fix missing_pages restore in resize rollback
>
> The rollback for a failed clustered-raid bitmap preallocation copies
> old_counts.pages into missing_pages instead of old_counts.missing_pages.
> The counter then reports every page as missing and can grow past the
> page count as pages are freed later, making the used_pages stat in
> /proc/mdstat wrap around. Accounting only, no corruption.
>
> Signed-off-by: Chengyu Liu <lui2012qwq@gmail.com>
[Severity: Low]
Should this include a Fixes tag for the commit that introduced the
preallocation rollback in __bitmap_resize()?
Fixes: c9d650322829 ("md-cluster: always setup in-memory bitmap")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107164305.11476-1-lui2012qwq@gmail.com?part=1
next prev parent reply other threads:[~2026-11-07 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 16:43 [PATCH] md/bitmap: fix missing_pages restore in resize rollback Chengyu Liu
2026-11-07 16:53 ` sashiko-bot [this message]
2026-11-07 17:56 ` Chengyu Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203076@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lui2012qwq@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.