Re: [PATCH 2/3] drm/xe: Exclude imported dma-buf BOs from the TT budget

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe: commit message body describes outdated v1
  sys_mgr_sg_usage design
--

commit 2d9d97becda400684fed39733d2674585c59c2c5
Author: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

drm/xe: Exclude imported dma-buf BOs from the TT budget

This commit excludes imported dma-buf BOs (ttm_bo_type_sg) from being
charged against the system TTM resource manager budget by tracking
charged allocations in xe->mem.sys_mgr_charged.

> Track the bytes of ttm_bo_type_sg BOs in a new per-device counter,
> mem.sys_mgr_sg_usage, and subtract it from the usage compared against
> the budget. The counter is maintained in xe_ttm_sys_mgr_new() and
> xe_ttm_sys_mgr_del().

[Severity: Low]
This isn't a bug, but this paragraph still describes the v1 design
(tracking ttm_bo_type_sg BOs in mem.sys_mgr_sg_usage and subtracting
them from manager usage), whereas the patch tracks non-imported BOs
directly in mem.sys_mgr_charged.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-oom-fun-v1-0-be9eb05b82ed@intel.com?part=2