From: sashiko-bot@kernel.org
To: "Matthew Parker" <mparker@arista.com>,
pratyush@kernel.org, mwalle@kernel.org,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-mtd@lists.infradead.org, "Adam Calabrigo" <adamc@arista.com>
Subject: Re: [PATCH v2] mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512
Date: Sun, 08 Nov 2026 02:56:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-203532@kernel.org> (raw)
In-Reply-To: <20261108024317.898917-1-mparker@arista.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mtd: spi-nor: gigadevice: missing SPI_NOR_4BIT_BP on GD25B512
entry
--
commit 80fcf8b510cb4dc992f3889cf33e42d0cc514639
Author: Matthew Parker <mparker@arista.com>
mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512
This commit adds a flash_info entry for the GigaDevice GD25B512 64 MiB SPI
NOR flash with Status Register locking enabled.
> diff --git a/drivers/mtd/spi-nor/gigadevice.c b/drivers/mtd/spi-nor/gigadevice.c
> index 6a2e6ebda1483..fe05c0f0370da 100644
> --- a/drivers/mtd/spi-nor/gigadevice.c
> +++ b/drivers/mtd/spi-nor/gigadevice.c
> @@ -64,6 +64,9 @@ static const struct flash_info gigadevice_nor_parts[] = {
> .id = SNOR_ID(0xc8, 0x40, 0x19),
> .name = "gd25q256",
> .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6,
> + }, {
> + .id = SNOR_ID(0xc8, 0x47, 0x1a),
> + .flags = SPI_NOR_HAS_LOCK,
> }, {
> .id = SNOR_ID(0xc8, 0x60, 0x16),
> .name = "gd25lq32",
[Severity: Medium]
Should this entry also set SPI_NOR_4BIT_BP in .flags?
The GD25B512 is a 64 MiB flash (1024 64 KiB blocks) that uses four Block
Protect bits (BP3:0 in Status Register 1 bits 5:2) to address its block
protection ranges. Without SPI_NOR_4BIT_BP, spi_nor_get_sr_bp_mask()
omits SR_BP3, so spi_nor_sr_lock() and spi_nor_get_min_prot_length_sr()
miscalculate protected ranges by a factor of 16 (locking the full chip
only protects 4 MiB), and spi_nor_try_unlock_all() or spi_nor_sr_unlock()
cannot detect or clear SR_BP3 if it is set.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108024317.898917-1-mparker@arista.com?part=1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2026-11-08 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 2:43 [PATCH v2] mtd: spi-nor: gigadevice: Add support for GigaDevice GD25B512 Matthew Parker
2026-11-08 2:43 ` Matthew Parker
2026-11-08 2:56 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203532@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adamc@arista.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mparker@arista.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.