Re: [PATCH v3 5/5] arm64: dts: lx2160a: describe the pad muxes as the DCFG RCW override

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: lx2160a: missing Fixes trailer for commit
  8a1365c7bbc1
--

commit 3777e1216f9485c20e69631bad60b9ee0a491582
Author: Vincent Jardin <vjardin@free.fr>

> arm64: dts: lx2160a: describe the pad muxes as the DCFG RCW override
>
> The pad muxes are fields of the RCW: read-only in RCWSR12..14, changed
> at runtime through the override registers in the DCSR view of DCFG,
> which read 0 until written.
>
> pinctrl-single on those registers, since commit 8a1365c7bbc1
> ("arm64: dts: lx2160a: add pinmux and i2c gpio to support bus recovery"),
> clears every other field of the word with its first pin state:
> a board whose RCW programs a non-zero pad mux loses those pads at the
> first I2C probe.
>
> Describe the pad mux as a child of the dcfg node, which gains its DCSR
> view and, as on the LS1028A, the addressing of its children:
> the child is at its RCWSR12 to RCWSR14 window, one group per RCW field,
> one function per encoding, driven by fsl,lx2160a-rcw-pinmux using
> fsl-guts. Labels and pin node names stay, so no consumer changes.
> The pinctrl-single node goes.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>

[Severity: Low]
Since this fixes the pad mux clearing issue introduced by the
pinctrl-single description, should this include a Fixes: trailer?

  Fixes: 8a1365c7bbc1 ("arm64: dts: lx2160a: add pinmux and i2c gpio to support bus recovery")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-for-upstream-lx2160a-rcw-pinmux-v1-v3-0-5a0063f1da9e@free.fr?part=5