Re: [for-next 3/4] RDMA/ionic: allocate a PD-scoped DMA MR

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] RDMA/ionic: build failure in ionic_fill_lif_cfg() due to
  missing rdma.cap
--

commit 71ee46b9e5e60e185b9553d17b2722a569d100ad
Author: Gregor Dick <gregor.dick@amd.com>

RDMA/ionic: allocate a PD-scoped DMA MR

This commit allocates a PD-scoped DMA MR via CREATE_MR with
IONIC_MRF_DMA_MR when the firmware advertises IONIC_GEN_CAP_DMA_MR.

[ ... ]

> diff --git a/drivers/infiniband/hw/ionic/ionic_lif_cfg.c b/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> index 66cee57442e7a..dcf54856603d4 100644
> --- a/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> +++ b/drivers/infiniband/hw/ionic/ionic_lif_cfg.c
> @@ -95,6 +95,7 @@ void ionic_fill_lif_cfg(struct ionic_lif *lif, struct ionic_lif_cfg *cfg)
>  	cfg->rq_expdb =
>  	    !!(lif->qtype_info[IONIC_QTYPE_RXQ].features & IONIC_QIDENT_F_EXPDB);
>  	cfg->alloc_qid_cap = ident->rdma.alloc_qid_cap;
> +	cfg->cap = le64_to_cpu(ident->rdma.cap);
>  }

[Severity: High]
Does this break the build when CONFIG_INFINIBAND_IONIC is enabled?
The rdma struct inside union ionic_lif_identity in
drivers/net/ethernet/pensando/ionic/ionic_if.h has no cap member.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107150249.1576835-4-abhijit.gangurde@amd.com?part=1