From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E08606A31C for ; Mon, 9 Nov 2026 05:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zw2VJORZ; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lvhxiug+ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:Reply-To: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date :Content-Transfer-Encoding:Content-Type:References:In-Reply-To:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ngLdVs5ADSc+NgiOyvdsEU2ojAZWKq+pUBeFdxdN+sA=; b=zw2VJORZASk23+lzjB9Vo5yxGd iEAAgwM28SOfpeJgKLif9yH9g0hPWOl/z2rha4gbyPnajGjf6d2qUXQpLXtrLmbKb+wGs0PTZkkLB aVNmy2M3ROLaITGEw0dXfzjFkMBFHBqCZK4aqdViVzGTdA4e3GUlAj8cqiUzYdNX0LqjhlzymyAqv DVaOFHv1QmfOAw63MUxxawYQfn3vSayBs3Ne3j/tkG7JZEY9HCFZJsbQulGxwDx8e8I0uHsYylY1Y vWvEIwW0pn8x17E4jszlygCWm3CNftoZvfdahCmqTqZ2GAU+nL6a9OL5qChDxAKd227VEZix4ieeN Q+t+sb2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQIJ4-0000000HSn8-2a8U; Mon, 09 Nov 2026 05:52:38 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xQIJ2-0000000HSn0-3Sdd for kexec@lists.infradead.org; Mon, 09 Nov 2026 05:52:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 12D1A43F81; Mon, 9 Nov 2026 05:52:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C4EC1F0089F; Mon, 9 Nov 2026 05:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794203555; bh=ngLdVs5ADSc+NgiOyvdsEU2ojAZWKq+pUBeFdxdN+sA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lvhxiug+ERAgyEb3q015lbkxsX0mFCoaNkuzkQF6afElu7r5uMW1MorylNaNp8Yar +jXHTdkrnARbVZhFpIAnMv/ddZWUuBsvFhpZXIso0yAUsE/SrKjnAy1uGscJTyUDlk aYkvbHBknQGPTMwxXhmDBBfpjFI98ujM7g48zfqgMYC8eXTZmQ3EnW5rp7475YSqk0 ZD17dKYztxfMZ9HSwhyTrlbEDW5WT0jcCgbW3CrM1zLCOAQ9rKbprFGGtYZTKZFJPd 89P6oT5HXDrSWmNvo8BwT7zOU0fHW8o7ENq71POAbiyOJBzYIGr23jwGw8z65neF1e qZmLhBfHmAkBw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 4/4] x86/vmware: Report guest crashes after kmsg dumpers To: "Zack Rusin" , "Andrew Morton" , "Petr Mladek" , "Baoquan He" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Dave Young" In-Reply-To: <4dc02120a69e0d4b21f1ea3a12b4aedf6f22e706.1794201807.git.zack.rusin@broadcom.com> References: <4dc02120a69e0d4b21f1ea3a12b4aedf6f22e706.1794201807.git.zack.rusin@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 09 Nov 2026 05:52:33 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Cc: "Michael S. Tsirkin" , Kees Cook , Dave Hansen , Stephen Brennan , Bo Gan , "H. Peter Anvin" , Jonathan Corbet , Brennan Lamoreaux , x86@kernel.org, Joel Granados , Alexey Makhalov , Eugenio Perez , Ingo Molnar , bcm-kernel-feedback-list@broadcom.com, Ajay Kaher , Bradley Morgan , John Ogness , virtualization@lists.linux.dev, Steven Rostedt , Maaz Mombasawala , Borislav Petkov , Shuah Khan , Michael Kelley , Randy Dunlap , kexec@lists.infradead.org, Ian Forbes , Sergey Senozhatsky , Thomas Gleixner Sender: "kexec" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > VMware accepts a structured guest-crash event, but a host configured with > backdoor.coredumpOnCrash may terminate the VM before the hypercall > returns. Keep this event separate from the log sender, which runs > earlier in panic. >=20 > Register a panic-only kmsg dumper with late_initcall_sync(), after built-= in > dumpers registered by then. Skip the event while a crash kernel is loaded > so the host cannot terminate the guest before kdump saves its vmcore. >=20 > Issue the event at most once. With CONFIG_PRINTK=3Dn, use a late INT_MIN > panic notifier. An unexpected dumper registration failure with printk > enabled leaves reporting disabled rather than overtaking working dumpers. >=20 > Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@= broadcom.com > Co-developed-by: Brennan Lamoreaux > Signed-off-by: Brennan Lamoreaux > Co-developed-by: Alexey Makhalov > Signed-off-by: Alexey Makhalov > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1794201807.gi= t.zack.rusin@broadcom.com?part=3D4 From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794203556; b=vLWzhTtT+4vBCBaBpA/c/DJJc7z5t+WlFDk0qCrkCxeudMEI6HNBMOxrhuxjPIpn4OoU YfCNCqgnsvUk+Q0YHCAnAlcwhVnplhhsd920Ej2tEEPr2HzgoBUbvX8CTz5yidZXPke7D vaKuCHdC3a70eO9TY+6OHL4JP9oEb1YhaN1xCU8RnZL9t/X+DsRY91e2+UqE6hwmr1s0s I5QpRd2DyG4iHLTArnaTZRh8xsU4CuFeEjXlkl/7YBEcqudm40JqcOhHpUSNnSqtJdMCV Rhvbb5j3ZEvne6v6CMB5oh6zJjyf4/35uMvymWwygXH8GREHfzBHi+U59aGZEcdz5/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794203556; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=ngLdVs5ADSc+NgiOyvdsEU2ojAZWKq+pUBeFdxdN+sA=; b=hQVv+2F9iB3n9G6YLFw+MEdhr3QJGfHsLRPTgIZnKZOmqcqVg3c0QTfT1LcWzldZdqkL fSD8oRsRUVo3C6fKDm6BJBPueAEuRhS1XUggwY2pH9YM6Dw2V+hDwQ/bN5icdCPyj6EdE UmiPjRW3mm0/Wq9Z/2worz+SkRL9cw7tU06e1dsEE0+kSui6juyhW8xHwlFiZFiXW49gt Jn/aLjmws5yfhXsQ/geywu6QPreHHiEx7EaGDhqpQsBPv4abblhMQ/0V1jal4474nLDTU 6lKnEJVlHrxU07dauBBaYxBqkulgo5LE9UELDwoj6VyZmlxNYviAKH9XrpCBh0F3Lsg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lvhxiug+; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57367606A31C for ; Mon, 9 Nov 2026 05:52:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=lvhxiug+ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C4EC1F0089F; Mon, 9 Nov 2026 05:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794203555; bh=ngLdVs5ADSc+NgiOyvdsEU2ojAZWKq+pUBeFdxdN+sA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=lvhxiug+ERAgyEb3q015lbkxsX0mFCoaNkuzkQF6afElu7r5uMW1MorylNaNp8Yar +jXHTdkrnARbVZhFpIAnMv/ddZWUuBsvFhpZXIso0yAUsE/SrKjnAy1uGscJTyUDlk aYkvbHBknQGPTMwxXhmDBBfpjFI98ujM7g48zfqgMYC8eXTZmQ3EnW5rp7475YSqk0 ZD17dKYztxfMZ9HSwhyTrlbEDW5WT0jcCgbW3CrM1zLCOAQ9rKbprFGGtYZTKZFJPd 89P6oT5HXDrSWmNvo8BwT7zOU0fHW8o7ENq71POAbiyOJBzYIGr23jwGw8z65neF1e qZmLhBfHmAkBw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 4/4] x86/vmware: Report guest crashes after kmsg dumpers Reply-To: sashiko-reviews@lists.linux.dev To: "Zack Rusin" , "Andrew Morton" , "Petr Mladek" , "Baoquan He" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Dave Young" Cc: "Borislav Petkov" , "Ajay Kaher" , "Alexey Makhalov" , x86@kernel.org, "Joel Granados" , "Thomas Gleixner" , "Ingo Molnar" , "Dave Hansen" , "H. Peter Anvin" , virtualization@lists.linux.dev, bcm-kernel-feedback-list@broadcom.com, "John Ogness" , "Steven Rostedt" , "Sergey Senozhatsky" , "Kees Cook" , "Jonathan Corbet" , "Bo Gan" , "Brennan Lamoreaux" , kexec@lists.infradead.org, "Guilherme G. Piccoli" , "Maaz Mombasawala" , "Shuah Khan" , "Randy Dunlap" , "Stephen Brennan" , "Michael Kelley" , "Ian Forbes" , "Bradley Morgan" , "Michael S. Tsirkin" , "Eugenio Perez" In-Reply-To: <4dc02120a69e0d4b21f1ea3a12b4aedf6f22e706.1794201807.git.zack.rusin@broadcom.com> References: <4dc02120a69e0d4b21f1ea3a12b4aedf6f22e706.1794201807.git.zack.rusin@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 09 Nov 2026 05:52:33 +0000 X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > VMware accepts a structured guest-crash event, but a host configured with > backdoor.coredumpOnCrash may terminate the VM before the hypercall > returns. Keep this event separate from the log sender, which runs > earlier in panic. >=20 > Register a panic-only kmsg dumper with late_initcall_sync(), after built-= in > dumpers registered by then. Skip the event while a crash kernel is loaded > so the host cannot terminate the guest before kdump saves its vmcore. >=20 > Issue the event at most once. With CONFIG_PRINTK=3Dn, use a late INT_MIN > panic notifier. An unexpected dumper registration failure with printk > enabled leaves reporting disabled rather than overtaking working dumpers. >=20 > Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@= broadcom.com > Co-developed-by: Brennan Lamoreaux > Signed-off-by: Brennan Lamoreaux > Co-developed-by: Alexey Makhalov > Signed-off-by: Alexey Makhalov > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1794201807.gi= t.zack.rusin@broadcom.com?part=3D4