Re: [PATCH v9 2/7] thermal/drivers/loongson2: Fix clamp() usage for thermal trip points

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] thermal/drivers/loongson2: incorrect Fixes tag in
  loongson2_thermal_set()
--

commit 7c662ff635bdb14cac997976404a99f9d5a1e734
Author: Binbin Zhou <zhoubinbin@loongson.cn>

> thermal/drivers/loongson2: Fix clamp() usage for thermal trip points
>
> clamp() takes the value to clamp as its first argument, followed by the
> minimum and maximum bounds. The current code passes the -40 and 125
> limits as the value instead, so the trip thresholds are not clamped to the
> supported sensor range.
>
> Correct the arguments so that low and high are clamped to [-40, 125].
>
> Cc: stable@vger.kernel.org
> Fixes: 734b5def91b5 ("thermal/drivers/loongson2: Add Loongson-2K2000 support")
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>

[Severity: Low]
Should the Fixes tag reference e7e3a7c35791 ("thermal/drivers/loongson-2: Add
thermal management support") instead?  Commit 734b5def91b5 ("thermal/drivers/loongson2:
Add Loongson-2K2000 support") did not modify loongson2_thermal_set(), whereas
the inverted clamp() arguments were introduced in e7e3a7c35791 ("thermal/drivers/loongson-2:
Add thermal management support") and later moved into loongson2_set_ctrl_regs()
calls in 6ef6d5ff5edd ("thermal/drivers/loongson2: Trivial code style
adjustment").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794211535.git.zhoubinbin@loongson.cn?part=2