Re: [PATCH for-next 3/3] RDMA/efa: Add Completion Actions support

[sashiko-bot@kernel.org]

> Completion actions are device-side effects triggered by work requests:
> when a work request completes, locally or at the remote side, the device
> performs the action, so completions can be observed without polling a
> completion queue.
> 
> Implement the control path. A memory completion action object pins a
> user buffer (VA or dmabuf) on a protection domain and yields the action
> id that work requests carry; on each completion the device modifies
> mem_modify_size bytes (1, 2 or 4) of that buffer with the operand the
> work request supplies. The buffer must be physically contiguous. The
> device also returns an action handle, which the driver keeps for the
> destroy command.
> 
> The object is an EFA ioctl object, exposed only when the device reports
> the actions capability. It holds a reference on its protection domain,
> so deallocating the PD while the action exists fails with EBUSY. QP
> creation accepts a WQE feature block configuration - an enablement
> bitmap and the offset of the action descriptor within the WQE -
> determined by the user space provider, which owns the WQE layout, and
> passed through to the device. The device capability, the maximum number
> of memory completion actions and the supported work request types are
> reported through query device.
> 
> Reviewed-by: Michael Margolin <mrgolin@amazon.com>
> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
> Signed-off-by: Ilia Kolominsky <ikolomin@amazon.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109081349.27316-1-ikolomin@amazon.com?part=3