Re: [PATCH v2] ALSA: core: Fix info read handling

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ALSA: core: missing Fixes trailer for commit d97e1b78239c
--

commit a395693d2a5039fea3a9bd10c727bfff30a92e11
Author: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

> ALSA: core: Fix info read handling
>
> snd_info_entry_read() may invoke driver read callbacks with a
> zero-length read when the requested count is zero.
>
> Some callbacks perform zero-sized allocations, such as
> vmalloc(0), which can trigger warnings and cause the read to
> fail with -ENOMEM.
>
> Return immediately when count is zero to avoid invoking driver
> callbacks unnecessarily.
>
> Also, store the callback result in a separate ssize_t variable
> instead of reusing the size_t variable. This makes the signedness
> explicit and avoids the unnecessary cast when checking whether
> to update the file position.
>
> Update the file position only when the callback returns a
> positive number of bytes.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>

[Severity: Low]
Driver read callbacks previously checked size > 0 themselves until those
checks were centralized in snd_info_entry_read() and snd_info_entry_write(),
where only snd_info_entry_write() guarded against count == 0.  Should this
include:

  Fixes: d97e1b78239c ("ALSA: info - Check file position validity in common layer")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109085922.3104-1-sreekuttan2156239@gmail.com?part=1