From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (lochnagar) Avoid oversized shifts for zero readings
Date: Mon, 09 Nov 2026 09:42:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-204732@kernel.org> (raw)
In-Reply-To: <20261109093453.5384-1-zhujun2@cmss.chinamobile.com>
> From: zhujun <zhujun2@cmss.chinamobile.com>
>
> A zero IEEE754 reading gives exp = -150 in float_to_long(). Both shifts
> in the rounding expression then exceed the width of u64. UBSAN reports a
> shift exponent of 149, and the conversion can return a nonzero reading.
>
> Return zero when the required right shift is at least 64 bits. With the
> supported precisions, the scaled mantissa is too small to round up in
> this case.
>
> Fixes: 4cdb56214746 ("hwmon: lochnagar: Add Lochnagar 2 hardware monitoring driver")
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109093453.5384-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:33 [PATCH] hwmon: (lochnagar) Avoid oversized shifts for zero readings Zhu Jun
2026-11-09 9:42 ` sashiko-bot [this message]
2026-11-09 11:18 ` Charles Keepax
2026-11-09 15:11 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:49 Zhu Jun
2026-11-11 6:59 ` sashiko-bot
2026-11-11 9:32 ` Charles Keepax
2026-11-11 22:34 ` Guenter Roeck
2026-11-12 2:19 ` Zhu Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204732@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.