From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (vt8231) Clamp voltage limits before scaling
Date: Mon, 09 Nov 2026 09:47:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-204742@kernel.org> (raw)
In-Reply-To: <20261109093739.5539-1-zhujun2@cmss.chinamobile.com>
> From: zhujun <zhujun2@cmss.chinamobile.com>
>
> The voltage limit stores multiply an unrestricted unsigned long before
> clamping the register value. Large inputs can wrap and select a low
> threshold. On 32-bit systems, writing 4483265 mV to a regular voltage
> limit selects register 3 instead of 255.
>
> Bound the input before multiplication, using the separate scaling for
> input 5. This preserves the conversion throughout the representable
> range.
>
> Fixes: 1de9e371b89e ("[PATCH] hwmon: New vt8231 driver")
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109093739.5539-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:37 [PATCH] hwmon: (vt8231) Clamp voltage limits before scaling Zhu Jun
2026-11-09 9:47 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:51 Zhu Jun
2026-11-11 7:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204742@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.