From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (w83627ehf) Clamp fan control times before rounding
Date: Mon, 09 Nov 2026 10:20:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-204801@kernel.org> (raw)
In-Reply-To: <20261109101657.16793-1-zhujun2@cmss.chinamobile.com>
> The fan time stores pass an unsigned long to step_time_to_reg(), which
> takes unsigned int. Large values can be truncated or overflow when the
> rounding adjustment is added. For example, 4294967295 ms selects
> register 1 instead of 255.
>
> Keep the input as unsigned long and bound it to the maximum duration
> before applying the PWM or DC mode conversion.
>
> Fixes: 08c79950a047 ("hwmon: Add fan speed control features to w83627ehf")
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109101657.16793-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:16 [PATCH] hwmon: (w83627ehf) Clamp fan control times before rounding Zhu Jun
2026-11-09 10:20 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:52 Zhu Jun
2026-11-11 7:00 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204801@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.