From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (it87) Bound 16-bit fan limits before conversion
Date: Mon, 09 Nov 2026 10:21:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-204802@kernel.org> (raw)
In-Reply-To: <20261109101726.16875-1-zhujun2@cmss.chinamobile.com>
> FAN16_TO_REG() doubles an unrestricted positive long and adds 1350000
> before dividing. Large fan limits can overflow these intermediate values
> and select an incorrect tachometer limit. Converting LONG_MAX can select
> 0xfffe instead of 1.
>
> Apply the same RPM bound used by the 8-bit conversion before doing the
> arithmetic. Keep zero as the alarm-disable value.
>
> Fixes: 17d648bf5786 ("it87: Add support for the IT8716F")
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109101726.16875-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:17 [PATCH] hwmon: (it87) Bound 16-bit fan limits before conversion Zhu Jun
2026-11-09 10:21 ` sashiko-bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:52 Zhu Jun
2026-11-11 6:59 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204802@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.