From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (lm85) Bound fan stop temperatures before subtraction
Date: Mon, 09 Nov 2026 10:26:33 +0000 [thread overview]
Message-ID: <sashiko-outbox-204816@kernel.org> (raw)
In-Reply-To: <20261109101936.17430-1-zhujun2@cmss.chinamobile.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] hwmon: (lm85) ambiguous 12-char SHA in Fixes trailer
--
commit bd3942e6e0ab99093810924c7c557da1e1780136
Author: Zhu Jun <zhujun2@cmss.chinamobile.com>
> hwmon: (lm85) Bound fan stop temperatures before subtraction
>
> temp_auto_temp_off_store() subtracts an unrestricted long from the zone
> limit before clamping the resulting hysteresis. Extreme inputs can
> overflow this subtraction and select the wrong end of the hysteresis
> range.
>
> Bound the requested stop temperature before calculating the difference.
> A signed 8-bit zone limit and a maximum hysteresis of 15 degrees require
> only the -143..127 degree range.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
[Severity: Low]
The 12-character prefix 1da177e4c3f4 in the Fixes: tag is ambiguous in the
kernel git repository and cannot be resolved cleanly. Should this use the
13-character prefix instead:
Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109101936.17430-1-zhujun2@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-09 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:19 [PATCH] hwmon: (lm85) Bound fan stop temperatures before subtraction Zhu Jun
2026-11-09 10:26 ` sashiko-bot [this message]
2026-11-09 15:12 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2026-11-11 6:53 Zhu Jun
2026-11-11 7:06 ` sashiko-bot
2026-11-11 16:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204816@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.