Re: [PATCH v2 2/5] gpio: shared: use atomic set_bit() for descriptor flags

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] gpio: shared: inaccurate second Fixes trailer in
  gpiochip_setup_shared()
--

commit e33d8a46a34364d4913f4b0279d4b95dddc4953e
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

> gpio: shared: use atomic set_bit() for descriptor flags
>
> Use the atomic set_bit() instead of __set_bit() on desc->flags so that
> every modification of the field uses atomic bitops. No functional change
> as these run before any line of the chip can be requested.
>
> Cc: stable@vger.kernel.org
> Fixes: eb374f764a70 ("gpio: provide gpiod_is_shared()")
> Fixes: 310a4a9cbb17 ("gpio: shared: shorten the critical section in gpiochip_setup_shared()")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

[Severity: Low]
310a4a9cbb17 ("gpio: shared: shorten the critical section in
gpiochip_setup_shared()") only re-indented the __set_bit(GPIOD_FLAG_SHARED,
&desc->flags) call when wrapping the block in scoped_guard().  The
non-atomic __set_bit(GPIOD_FLAG_SHARED, ...) call was originally introduced
in a060b8c511ab ("gpiolib: implement low-level, shared GPIO support").

Should the second Fixes: tag instead be:

  Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-gpio-desc-flags-atomic-v2-0-c4c54b476628@oss.qualcomm.com?part=2