Re: [PATCH v4 2/4] perf dwarf-aux: Support DW_OP_addrx locations for global variables

[sashiko-bot@kernel.org]

> die_find_variable_by_addr() and die_collect_global_vars() only accept
> global variables with a DW_OP_addr location. DWARF 5 producers like
> clang use DW_OP_addrx instead, which is an index into .debug_addr, so
> global variables are never found when Perf is built with LLVM=1.
> 
> Add a helper that also resolves DW_OP_addrx and DW_OP_GNU_addr_index
> through dwarf_getlocation_attr() and dwarf_formaddr(), and use it in
> both places. This fixes the "perf data type profiling tests" test:
> 
>   $ perf test -vvv "perf data type profiling tests"
>   ...
>   Basic C perf annotate test
>   Basic annotate [Failed: missing target data type]
>   ...
>   Pipe C perf annotate test
>   Pipe annotate [Failed: missing target data type]
>   ...
>   Basic FS perf annotate test
>   Basic annotate [Failed: missing target data type]
>   ...
>   Pipe FS perf annotate test
>   Pipe annotate [Failed: missing target data type]
>   ---- end(-1) ----
>    88: perf data type profiling tests : FAILED!
> 
> Fixes: d60469d7c0e5 ("perf dwarf-aux: Add die_find_variable_by_addr()")
> Signed-off-by: James Clark <james.clark@linaro.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-james-perf-test-fixes-v4-0-355ee6b81917@linaro.org?part=2