From: sashiko-bot@kernel.org
To: "Rob Clark" <robin.clark@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 05/15] drm/msm/a8xx: Add missing a850 ifpc reglist entries
Date: Mon, 09 Nov 2026 14:33:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-205112@kernel.org> (raw)
In-Reply-To: <20261109142111.256630-6-robin.clark@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/msm/a8xx: missing Fixes trailer on a850_ifpc_reglist_regs
bug fix
--
commit 54d9bf20de92bf3a72deb192459f9ce0ff04d4f2
Author: Rob Clark <robin.clark@oss.qualcomm.com>
> drm/msm/a8xx: Add missing a850 ifpc reglist entries
>
> We want to save/restore all of the CP_PROTECT regs across IFPC.
>
> Tested-by: Alexander Koskovich <akoskovich@pm.me> # Milos (Nothing Phone 3a)
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
[Severity: Low]
Since a850_ifpc_reglist_regs was introduced without
REG_A8XX_CP_PROTECT_GLOBAL(56..62), leaving REG_A8XX_CP_PROTECT_GLOBAL(56)
from the 57-entry a850_protect_regs table unsaved across IFPC power
collapse, should this include:
Fixes: b0e029f7cf87 ("drm/msm/a8xx: Add Adreno 850 support")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109142111.256630-1-robin.clark@oss.qualcomm.com?part=5
next prev parent reply other threads:[~2026-11-09 14:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 14:19 [PATCH v8 00/15] drm/msm/a8xx: GPU state capture support Rob Clark
2026-11-09 14:19 ` [PATCH v8 01/15] drm/msm: Import adreno_snapshot.h Rob Clark
2026-11-09 14:29 ` sashiko-bot
2026-11-09 14:19 ` [PATCH v8 02/15] drm/msm/a8xx: Export aperture helpers Rob Clark
2026-11-09 14:19 ` [PATCH v8 03/15] drm/msm/a8xx: Add a8xx_aperture_acquire_raw() Rob Clark
2026-11-09 14:19 ` [PATCH v8 04/15] drm/msm/a8xx: Export slice helper Rob Clark
2026-11-09 14:19 ` [PATCH v8 05/15] drm/msm/a8xx: Add missing a850 ifpc reglist entries Rob Clark
2026-11-09 14:33 ` sashiko-bot [this message]
2026-11-09 14:19 ` [PATCH v8 06/15] drm/msm/a8xx: Allow nonctx reglist to include GMU regs Rob Clark
2026-11-09 14:19 ` [PATCH v8 07/15] drm/msm/a8xx: Stop getting GMEM_PROTECT from nonctx list Rob Clark
2026-11-09 14:19 ` [PATCH v8 08/15] drm/msm/adreno: Fix PROTECT span length Rob Clark
2026-11-09 14:32 ` sashiko-bot
2026-11-09 14:19 ` [PATCH v8 09/15] drm/msm/adreno: add temporary __maybe_unused Rob Clark
2026-11-09 14:19 ` [PATCH v8 10/15] drm/msm/a8xx: Import generated headers Rob Clark
2026-11-09 14:19 ` [PATCH v8 11/15] drm/msm/a8xx: devcoredump state capture support Rob Clark
2026-11-09 14:48 ` sashiko-bot
2026-11-09 14:19 ` [PATCH v8 12/15] drm/msm/a8xx: Add all CP_PROTECT_PIPE to pwrup reglist Rob Clark
2026-11-09 14:19 ` [PATCH v8 13/15] drm/msm/a8xx: Use CP_PROTECT_PIPE regs Rob Clark
2026-11-09 14:20 ` [PATCH v8 14/15] drm/msm/a8xx: Switch to generated protect regs Rob Clark
2026-11-09 14:20 ` [PATCH v8 15/15] drm/msm/adreno: Remove temporary __maybe_unused Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205112@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.