From: sashiko-bot@kernel.org
To: "Tejun Heo" <tj@kernel.org>
Cc: sched-ext@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-7.5] selftests/sched_ext: Fix enable_cmask load failure on older clangs
Date: Mon, 09 Nov 2026 16:32:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-205236@kernel.org> (raw)
In-Reply-To: <20261109162623.674441-1-tj@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/sched_ext: missing Fixes: trailer for
enable_cmask_enable() fix
--
commit 948cafa51d1e3328d46bf77feab57f93ed6e21e0
Author: Tejun Heo <tj@kernel.org>
> selftests/sched_ext: Fix enable_cmask load failure on older clangs
>
> enable_cmask casts the u64 arena address of the task's cmask to an __arena
> pointer without cast_kern(). Older clangs without
> __BPF_FEATURE_ADDR_SPACE_CAST need the explicit cast, so the test fails to
> load there. Add it.
>
> Reported-by: Zhijian Han <hanzhijian1991@gmail.com>
> Closes: https://lore.kernel.org/all/6af1e5f2.a438010f.130489.ab94@mx.google.com/
> Signed-off-by: Tejun Heo <tj@kernel.org>
[Severity: Low]
Should this commit include a Fixes: tag for the commit that added the test?
Fixes: d781d1b78acf ("selftests/sched_ext: Check the cmask cid-form ops.enable() receives")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109162623.674441-1-tj@kernel.org?part=1
prev parent reply other threads:[~2026-11-09 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 15:25 sched_ext selftest enable_cmask fails to load on 7.4-rc2: verifier rejects arena pointer cast from scx_enable_args.cmask_arena_addr Zhijian Han
2026-11-09 16:26 ` [PATCH sched_ext/for-7.5] selftests/sched_ext: Fix enable_cmask load failure on older clangs Tejun Heo
2026-11-09 16:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205236@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.