From: sashiko-bot@kernel.org
To: "Robin Murphy" <robin.murphy@arm.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf/arm-cmn: Sanity-check DTC discovery
Date: Mon, 09 Nov 2026 17:51:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-205345@kernel.org> (raw)
In-Reply-To: <a1abc2ce99b91db64948cfc3b639c878f896858c.1794245895.git.robin.murphy@arm.com>
> With the device isolation feature, the control registers reset to
> the "all ports disabled" value and so require explicit programming
> by pre-boot firmware. Apparently if firmware forgets to do this,
> we can end up skipping all leaf nodes in the discovery walk due to
> the CMN_CHILD_NODE_ISOLATED flag, and thus dereferencing dtc[0]
> uninitialised in arm_cmn_set_state(). While this should only ever
> be an "early platform bringup" kind of issue, it's not too hard to
> fail a bit more politely in this case, so we may as well.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/a1abc2ce99b91db64948cfc3b639c878f896858c.1794245895.git.robin.murphy@arm.com?part=1
prev parent reply other threads:[~2026-11-09 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 17:38 [PATCH] perf/arm-cmn: Sanity-check DTC discovery Robin Murphy
2026-11-09 17:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205345@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.