From: sashiko-bot@kernel.org
To: "Thorsten Lannynd" <t-lannynd@ti.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am67a-beagley-ai: Add orientation to IMX219 sensors
Date: Mon, 09 Nov 2026 18:19:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-205397@kernel.org> (raw)
In-Reply-To: <20261109180859.4139929-1-t-lannynd@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: ti: missing Fixes trailers for BeagleY-AI IMX219
overlays
--
commit b82931b5cae82dbfddb19d7077db1533a5aa02a0
Author: Thorsten Lannynd <t-lannynd@ti.com>
> arm64: dts: ti: k3-am67a-beagley-ai: Add orientation to IMX219 sensors
>
> The IMX219 CSI2 expansion modules are externally attached. Without the
> orientation property, V4L2_CID_CAMERA_ORIENTATION (0x009a0922) is not
> exposed and libcamera fails with:
>
> ERROR CameraSensor camera_sensor_raw.cpp:465 'imx219 4-0010':
> Mandatory V4L2 control 0x009a0922 not available
>
> Set orientation = <MEDIA_ORIENTATION_EXTERNAL> on both CSI0 and CSI1
> sensor nodes to fix this.
>
> Signed-off-by: Thorsten Lannynd <t-lannynd@ti.com>
[Severity: Low]
Since this fixes the IMX219 camera overlays failing in libcamera due to the
missing orientation property, should it include the following Fixes tags?
Fixes: e0c1c2492be4 ("arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI0")
Fixes: bb58f1c72c5c ("arm64: dts: ti: k3-am67a-beagley-ai: Add overlay for IMX219 on CSI1")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109180859.4139929-1-t-lannynd@ti.com?part=1
prev parent reply other threads:[~2026-11-09 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 18:08 [PATCH 1/3] arm64: dts: ti: k3-am67a-beagley-ai: Add orientation to IMX219 sensors Thorsten Lannynd
2026-11-09 18:08 ` [PATCH 2/3] arm64: dts: ti: k3-j721e-sk: " Thorsten Lannynd
2026-11-09 18:08 ` [PATCH 3/3] arm64: dts: ti: k3-j722s-evm: " Thorsten Lannynd
2026-11-09 18:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205397@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=t-lannynd@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.