Re: [PATCH v5 6/6] selftests/x86: add generic prctl shadow stack test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/x86: duplicate test_shadow_stack entry in
  TARGETS_C_64BIT_ONLY
--

commit 52e57f66207c4b662bab2432ff697c9236a6020d
Author: Bill Roberts <bill.roberts@arm.com>

selftests/x86: add generic prctl shadow stack test

This commit refactors the x86 shadow stack selftest into a shared
implementation and adds a test_shadow_stack_prctl entry point to exercise
the generic prctl() shadow stack operations alongside arch_prctl().

> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index effbfe9b269f3..48c7459091614 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -20,7 +20,7 @@ TARGETS_C_32BIT_ONLY := entry_from_vm86 test_syscall_vdso unwind_vdso \
>  			vdso_restorer
>  TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip syscall_numbering \
>  			corrupt_xstate_header amx lam test_shadow_stack avx apx \
> -			sigframe_fpu_portability
> +			sigframe_fpu_portability test_shadow_stack test_shadow_stack_prctl

[Severity: Low]
Does adding test_shadow_stack here duplicate the existing entry on the
previous line of TARGETS_C_64BIT_ONLY?  Because BINARIES_64 and TEST_PROGS
expand TARGETS_C_64BIT_ONLY without deduplication, make warns about duplicate
target recipes for test_shadow_stack_64 and kselftest runs the binary twice.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109182758.252223-1-bill.roberts@arm.com?part=6