Re: [PATCH v3 3/9] dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: remoteproc: qcom,adsp: piling on per-compatible
  conditional
--

commit d08998077e2bf791171ccb3e3fc451fa5b6952ed
Author: Richard Acayan <mailingradian@gmail.com>

dt-bindings: remoteproc: qcom: adsp: Add SDM670 ADSP compatible

This commit adds the qcom,sdm670-adsp-pas compatible and its LCX power
domain constraints to the qcom,adsp.yaml binding schema.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 7e8ecae8e6cb6..6cac1f77993ba 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -25,6 +25,7 @@ properties:
>        - qcom,msm8998-slpi-pas
>        - qcom,sdm660-adsp-pas
>        - qcom,sdm660-cdsp-pas
> +      - qcom,sdm670-adsp-pas
>        - qcom,sdm845-adsp-pas
>        - qcom,sdm845-cdsp-pas
>        - qcom,sdm845-slpi-pas
> @@ -128,6 +129,20 @@ allOf:
>        required:
>          - px-supply
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,sdm670-adsp-pas
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: LCX power domain
> +        power-domain-names:
> +          items:
> +            - const: lcx

[Severity: Low]
Should qcom,sdm670-adsp-pas be split into a separate schema document (or
grouped with a matching PAS binding) instead of adding another
per-compatible if-then block to qcom,adsp.yaml?

qcom,adsp.yaml already carries several variant-specific conditionals under
allOf for different power domain and supply layouts, and newer PAS bindings
with distinct constraints have been split into dedicated schema files to
keep the conditionals manageable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107022453.159341-1-mailingradian@gmail.com?part=3