Re: [PATCH] nvme-pci: add NVME_QUIRK_NO_DEEPEST_PS for Lexar NQ790

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] nvme-pci: unreachable duplicate PCI ID entries in
  nvme_id_table [1]
--

commit 429e3e2e059a46cae1c4b2dd37e74978a88e3c7d
Author: Platon Miller <platon.ksenzenkokk@gmail.com>

nvme-pci: add NVME_QUIRK_NO_DEEPEST_PS for Lexar NQ790

This commit adds the NVME_QUIRK_NO_DEEPEST_PS quirk for the Lexar NQ790
SSD (PCI ID 1d97:5236) to prevent it from entering its non-operational
PS4 state via APST.

> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index f8088d5aa724c..5414b16d44387 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -4508,6 +4508,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  	{ PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */
>  		.driver_data = NVME_QUIRK_BOGUS_NID |
>  				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> +	{ PCI_DEVICE(0x1d97, 0x5236), /* Lexar NQ790 / NM800 PRO */
> +		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },

[Severity: Medium]
This problem wasn't introduced by this patch, but nvme_id_table contains
duplicate PCI ID entries for 0x1d97:0x2263 [1]:

drivers/nvme/host/pci.c:nvme_id_table[] = {
    ...
	{ PCI_DEVICE(0x1d97, 0x2263),   /* SPCC */
		.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
    ...
	{ PCI_DEVICE(0x1d97, 0x2263), /* Lexar NM610 */
		.driver_data = NVME_QUIRK_BOGUS_NID, },
    ...
};

Because pci_match_device() stops at the first matching vendor and device
ID, is the Lexar NM610 entry unreachable, leaving those drives with
NVME_QUIRK_DISABLE_WRITE_ZEROES instead of NVME_QUIRK_BOGUS_NID?

[1] https://sashiko.dev/#/bug/linux-6e3b737e-406a-4fa3-94f8-00407fa27202

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109201503.10098-1-platon.ksenzenkokk@gmail.com?part=1