From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] gpio: Add Siflower GPIO controller driver
Date: Mon, 09 Nov 2026 20:21:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-205573@kernel.org> (raw)
In-Reply-To: <20261109-sf19a2890-gpio-v2-2-b885fbd84c4c@telaak.dev>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] gpio: siflower: Kconfig dependency on undefined symbol
MACH_SIFLOWER_MIPS
--
commit 7d4cf03fe67bddda82068aa514774129a210dcc8
Author: Qingfang Deng <qingfang.deng@siflower.com.cn>
gpio: Add Siflower GPIO controller driver
This commit adds a driver for the GPIO controller on Siflower MIPS and
RISC-V SoCs.
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 55e4280029d86..623c09832bebc 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -721,6 +721,18 @@ config GPIO_SIFIVE
> help
> Say yes here to support the GPIO device on SiFive SoCs.
>
> +config GPIO_SIFLOWER
> + tristate "Siflower GPIO support"
> + depends on MACH_SIFLOWER_MIPS || COMPILE_TEST
[Severity: Medium]
Is MACH_SIFLOWER_MIPS defined in Kconfig? Because the symbol does not
exist in the tree, CONFIG_GPIO_SIFLOWER cannot be enabled unless
CONFIG_COMPILE_TEST is set.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-sf19a2890-gpio-v2-1-b885fbd84c4c@telaak.dev?part=2
prev parent reply other threads:[~2026-11-09 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 20:09 [PATCH v2 0/2] gpio: Add the Siflower SF19A2890 GPIO controller Joseph Telaak via B4 Relay
2026-11-09 20:09 ` Joseph Telaak
2026-11-09 20:09 ` [PATCH v2 1/2] dt-bindings: gpio: Add " Joseph Telaak via B4 Relay
2026-11-09 20:09 ` Joseph Telaak
2026-11-10 13:24 ` Krzysztof Kozlowski
2026-11-09 20:09 ` [PATCH v2 2/2] gpio: Add Siflower GPIO controller driver Joseph Telaak via B4 Relay
2026-11-09 20:09 ` Joseph Telaak
2026-11-09 20:21 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205573@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joseph@telaak.dev \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.