From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v11 07/20] perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso()
Date: Mon, 09 Nov 2026 20:41:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-205595@kernel.org> (raw)
In-Reply-To: <20261107044102.1506626-8-irogers@google.com>
> __machine__addnew_vdso() called __dsos__add(&machine->dsos, dso) without
> holding machine->dsos.lock, and machine__findnew_vdso() and
> __machine__findnew_compat() initialized machine->vdso_info and created
> temporary VDSO files without synchronization. Acquire
> machine->dsos.lock in write mode across machine->vdso_info
> initialization, duplicate checking via __dsos__find(), temporary file
> creation, dso__set_long_name(), and __dsos__add().
>
> Fixes: f649ed80f3ca ("perf dsos: Tidy reference counting and locking")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107044102.1506626-1-irogers@google.com?part=7
next prev parent reply other threads:[~2026-11-09 20:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 4:40 [PATCH v11 00/20] tools/perf: Adopt kernel compiler-context-analysis.h annotations Ian Rogers
2026-11-07 4:40 ` [PATCH v11 01/20] compiler-context-analysis: Avoid unused parameter warning in _context_unsafe_alias() Ian Rogers
2026-11-09 19:55 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 02/20] tools headers compiler: Synchronize compiler_types.h with the kernel sources Ian Rogers
2026-11-09 20:01 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 03/20] tools headers: Synchronize linux/compiler-context-analysis.h " Ian Rogers
2026-11-09 20:04 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 04/20] perf mutex: Use kernel style compiler-context-analysis.h annotations Ian Rogers
2026-11-09 20:11 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 05/20] perf build: Enable additional Clang thread-safety flags Ian Rogers
2026-11-09 20:23 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 06/20] perf comm: Add __guarded_by annotations to struct comm_strs Ian Rogers
2026-11-09 20:37 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 07/20] perf vdso: Fix unlocked __dsos__add() and race in __machine__addnew_vdso() Ian Rogers
2026-11-09 20:41 ` sashiko-bot [this message]
2026-11-07 4:40 ` [PATCH v11 08/20] perf dsos: Skip BPF and OOL DSOs in dsos__find_kernel_dso() Ian Rogers
2026-11-09 20:59 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 09/20] perf dsos: Ensure DSOs in auxtrace, machine, and symbol are in dsos Ian Rogers
2026-11-09 21:08 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 10/20] perf dso: Pass dso_data to close_data_fd() and dso__list_del() Ian Rogers
2026-11-09 21:13 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 11/20] perf dso: Use DEFINE_MUTEX for dso__data_open_lock Ian Rogers
2026-11-09 21:14 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 12/20] perf dsos: Use read lock fast path in dsos__findnew_id() Ian Rogers
2026-11-09 21:19 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 13/20] perf dso: Expand context analysis annotations Ian Rogers
2026-11-09 21:21 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 14/20] perf thread: Expand context analysis annotations to threads and namespaces_lock Ian Rogers
2026-11-09 21:25 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 15/20] perf intel-tpebs: Fix race in tpebs_stop() and tpebs_cmd.out fd handling Ian Rogers
2026-11-09 21:50 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 16/20] perf intel-tpebs: Use DEFINE_MUTEX for tpebs_mtx Ian Rogers
2026-11-09 21:58 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 17/20] perf config, intel-tpebs, env: Add __guarded_by and __must_hold annotations Ian Rogers
2026-11-09 22:06 ` sashiko-bot
2026-11-07 4:40 ` [PATCH v11 18/20] perf maps: Fix lock inversion in maps__load_first() Ian Rogers
2026-11-09 22:10 ` sashiko-bot
2026-11-07 4:41 ` [PATCH v11 19/20] perf maps: Fix map index lookup fallback and removal Ian Rogers
2026-11-09 22:17 ` sashiko-bot
2026-11-07 4:41 ` [PATCH v11 20/20] perf maps: Add context analysis annotations Ian Rogers
2026-11-09 22:24 ` sashiko-bot
2026-11-10 22:58 ` [PATCH v11 00/20] tools/perf: Adopt kernel compiler-context-analysis.h annotations Namhyung Kim
2026-11-10 23:14 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205595@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.