Re: [RFC PATCH 10/11] PCI: Move Ricoh RL5C476 MMC quirk to setup-cardbus.c

[sashiko-bot@kernel.org]

> ricoh_mmc_fixup_rl5c476() disables the proprietary MMC controller of the
> Ricoh RL5C476 through Function 0 of the chip, which is a CardBus bridge.
> When CONFIG_CARDBUS is not set, CardBus bridges are ignored and, as
> Function 0 is then missing, pci_scan_slot() does not enumerate the other
> Functions of the chip either. The quirk has nothing to do in that case.
> 
> Move the quirk to setup-cardbus.c so it is only built with CARDBUS.
> CARDBUS defaults to y when CONFIG_PCCARD is enabled, so existing configs
> for systems with these chips should mostly keep the quirk.
> 
> CONFIG_MMC_RICOH_MMC is an option of the SDHCI PCI card reader driver
> (CONFIG_MMC_SDHCI_PCI), which drives the SD controller of both the
> RL5C476 and the R5C832 family. On the R5C832 family, the MMC controller
> is disabled through the FireWire Function, which does not need CardBus.
> Thus, do not make MMC_RICOH_MMC depend on CARDBUS.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109210714.3862-1-ilpo.jarvinen@linux.intel.com?part=10