From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"David Howells" <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-s390@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Anna Schumaker" <anna@kernel.org>,
"Bharath SM" <bharathsm@microsoft.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Biggers" <ebiggers@kernel.org>,
"Eric Dumazet" <edumazet@kernel.org>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"James Morris" <jmorris@namei.org>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Namjae Jeon" <linkinjeon@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Paul Moore" <paul@paul-moore.com>,
"Paulo Alcantara" <pc@manguebit.org>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Shyam Prasad N" <sprasad@microsoft.com>,
"Simon Horman" <horms@kernel.org>,
"Sumit Garg" <sumit.garg@kernel.org>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Tom Talpey" <tom@talpey.com>,
"Trond Myklebust" <trondmy@kernel.org>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Chuck Lever" <cel@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>
Subject: Re: [PATCH v5 06/12] KEYS: trusted: TEE: Synchronize session lifetime
Date: Mon, 09 Nov 2026 22:28:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-205732@kernel.org> (raw)
In-Reply-To: <20261108222719.304712-7-jarkko@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] KEYS: trusted: missing Fixes trailers for TEE lifetime and
init_trusted() fixes
--
commit 081b81fce481c8193427ac02abce847085159640
Author: Jarkko Sakkinen <jarkko@kernel.org>
> KEYS: trusted: TEE: Synchronize session lifetime
>
> The parent TEE device can remove the client device while live instances
> keep trusted.ko loaded.
>
> Update the static calls before invoking backend init() and reset them in
> the case of a failure.
>
> In the TEE backend, guard session context state with a mutex, publish
> pvt_data.dev before registering key_type_trusted and sanitize pvt_data on
> probe failure and removal.
>
> When an active TEE has not been bound, reject seal, unseal and get_random
> with -ENODEV.
>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
[Severity: Low]
Should this include Fixes: tags for the TEE session lifetime handling and
the static call ordering in init_trusted()?
Fixes: 0a95ebc91305 ("KEYS: trusted: Introduce TEE based Trusted Keys")
Fixes: 31de287345f4 ("KEYS: trusted: Rollback init_trusted() consistently")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261108222719.304712-1-jarkko@kernel.org?part=6
next prev parent reply other threads:[~2026-11-09 22:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 22:27 [PATCH v5 00/12] KEYS: Sanitize the garbage collector Jarkko Sakkinen
2026-11-08 22:27 ` [PATCH v5 01/12] KEYS: Add key_gc_flush() for draining RCU callbacks Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 02/12] dns_resolver: Move the key type into a separate module Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 03/12] NFSv4: Clear idmap keyring cache when the last client unloads Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 04/12] smb: client: Clear idmap/SPNEGO caches when the last session is unloaded Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 05/12] s390/cert_store: Start tracking subsystem keys Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 06/12] KEYS: trusted: TEE: Synchronize session lifetime Jarkko Sakkinen
2026-11-09 6:55 ` Sumit Garg
2026-11-09 22:28 ` sashiko-bot [this message]
2026-11-09 23:13 ` Jarkko Sakkinen
2026-11-08 22:27 ` [PATCH v5 07/12] KEYS: trusted: TEE: Disable sysfs bind attributes Jarkko Sakkinen
2026-11-09 7:27 ` Sumit Garg
2026-11-09 15:16 ` Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 08/12] rxrpc: Release conn->key when init_connection_security() fails Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 09/12] rxrpc: Move key types to their own module Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 10/12] KEYS: Pin the backing kernel module for a key type Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 11/12] KEYS: Remove key_type_dead Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
2026-11-08 22:27 ` [PATCH v5 12/12] KEYS: key_garbage_collector(): process in chunks Jarkko Sakkinen
2026-11-09 22:28 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205732@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=anna@kernel.org \
--cc=bharathsm@microsoft.com \
--cc=borntraeger@linux.ibm.com \
--cc=cel@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=jarkko@kernel.org \
--cc=jlayton@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=serge@hallyn.com \
--cc=sprasad@microsoft.com \
--cc=sumit.garg@kernel.org \
--cc=svens@linux.ibm.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.