Re: [PATCH 6/6] arm64: dts: qcom: sm6115: Add Motorola Moto G9 Power (cebu)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [High] arm64: dts: qcom: undefined vreg_l9a phandle breaks
  cebu-tianma.dtb build
- [Medium] arm64: dts: qcom: sm6115-motorola-cebu-tianma leaves mdss
  enabled
- [Medium] arm64: dts: qcom: missing pinctrl-0 on uart3 breaks
  pinctrl_dt_to_map()
- [Medium] arm64: dts: qcom: unbound pmi632_lcdb regulator causes panel
  EPROBE_DEFER
- [Low] arm64: dts: qcom: unit_address_vs_reg warning on
  framebuffer@5c000000
--

commit 0fc3db560c7afce7509df398d557194333dec028
Author: Val Packett <val@packett.cool>

arm64: dts: qcom: sm6115: Add Motorola Moto G9 Power (cebu)

This commit adds the shared cebu devicetree include and a board devicetree for
the Motorola Moto G9 Power with the Tianma display panel.

> diff --git a/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu-tianma.dts b/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu-tianma.dts
> new file mode 100644
> index 0000000000000..31ca51570ea20
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu-tianma.dts
> @@ -0,0 +1,18 @@
[ ... ]
> +&dispcc {
> +	/* Preserve the bootloader display until the native panel is supported */
> +	status = "disabled";
> +};

[Severity: Medium]
Should &mdss, &mdss_dsi0 and &mdss_dsi0_phy also be disabled here?

sm6115-motorola-common.dtsi enables those nodes, and &mdss requires
power-domains = <&dispcc MDSS_GDSC> as well as clocks and resets from
&dispcc.  Leaving &mdss enabled while &dispcc is disabled keeps &mdss in
deferred probe and blocks sync_state on its active suppliers (gcc,
apps_smmu, mmrt_virt, bimc and config_noc) until deferred_probe_timeout
expires.

> diff --git a/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu.dtsi b/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu.dtsi
> new file mode 100644
> index 0000000000000..6f5263a67319f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm6115-motorola-cebu.dtsi
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (c) 2026, Val Packett <val@packett.cool>
> + */
> +
> +#include "sm6115.dtsi"
> +#include "sm6115-motorola-common.dtsi"

[Severity: Medium]
Does &uart3 in sm6115-motorola-common.dtsi need a pinctrl-0 property?

&uart3 sets pinctrl-names = "default", "sleep" and pinctrl-1 =
<&qup_uart3_sleep>, and the base uart3 node in sm6115.dtsi defines no
pinctrl-0.  When uart3 probes, pinctrl_dt_to_map() fails with -ENODEV on
state 0 when pinctrl-0 is missing, so neither the default pin state nor
qup_uart3_sleep is applied and dtbs_check fails.

[Severity: Medium]
Can panel@0 in sm6115-motorola-common.dtsi ever resolve avdd-supply =
<&pmi632_lcdb_ldo> and avee-supply = <&pmi632_lcdb_ncp>?

Commit "arm64: dts: qcom: pmi632: Add LCDB regulator node" adds
pmi632_lcdb: regulator@ec00 with compatible = "qcom,pmi632-lcdb",
"qcom,pm8150l-lcdb", which has no in-tree driver or binding schema.
This fails dtbs_check against qcom,spmi-pmic.yaml on sm6115-motorola-cebu-tianma.dtb,
and once the panel is enabled (as on sm6115-motorola-guamp-holitech.dtb),
of_regulator_dev_lookup() finds the DT node with no registered regulator
device and returns -EPROBE_DEFER permanently.

> +
> +&framebuffer0 {
> +	height = <1640>;
> +};

[Severity: High]
Does building sm6115-motorola-cebu-tianma.dtb fail with an undefined
phandle reference on framebuffer0?

In sm6115-motorola-common.dtsi, framebuffer0 sets vddio-supply =
<&vreg_l9a>, whereas the PM6125 LDO9 node in that file is labeled
pm6125_l9a:

arch/arm64/boot/dts/qcom/sm6115-motorola-common.dtsi:
		framebuffer0: framebuffer@5c000000 {
    ...
			vddio-supply = <&vreg_l9a>;
		};

dtc aborts compilation with:
ERROR (phandle_references): /chosen/framebuffer@5c000000: Reference to non-existent node or label "vreg_l9a"

[Severity: Low]
In addition, framebuffer0 in sm6115-motorola-common.dtsi is named
framebuffer@5c000000 but uses memory-region = <&cont_splash_memory>
without a reg property, which triggers dtc unit_address_vs_reg and
avoid_unnecessary_addr_size warnings under W=1 / dtbs_check.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109221453.658316-1-val@packett.cool?part=6