All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Gaurav Suman" <gauravsuman007@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	media-ci@linuxtv.org
Subject: Re: [PATCH 3/8] dt-bindings: media: i2c: Add Samsung S5K3M3 image sensor
Date: Mon, 09 Nov 2026 22:43:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-205766@kernel.org> (raw)
In-Reply-To: <20261109-sm8150-camera-v1-3-3d2e7b407516@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: media: samsung,s5k3m3: description refers to driver
  support
--

commit 4922a603dc5707d1a4718e4be230c423c1f7953c
Author: Gaurav Suman <gauravsuman007@gmail.com>

dt-bindings: media: i2c: Add Samsung S5K3M3 image sensor

This commit adds the Devicetree binding schema for the Samsung S5K3M3 13MP
image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml
> new file mode 100644
> index 0000000000000..434f5d4326b72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/samsung,s5k3m3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S5K3M3 Image Sensor
> +
> +description:
> +  Samsung S5K3M3 (ISOCELL 3M3) is a 13MP image sensor controlled over a
> +  serial camera control bus. The driver supports 4160x3120 at 30 frames per
> +  second, RAW10 over a 4-lane MIPI D-PHY interface.

[Severity: Low]
Should this description describe the hardware capabilities of the sensor
rather than what the driver supports, per
Documentation/devicetree/bindings/writing-bindings.rst?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-sm8150-camera-v1-0-3d2e7b407516@gmail.com?part=3

  reply	other threads:[~2026-11-09 22:43 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 22:38 [PATCH 0/8] Add SM8150 CAMSS and LG G8x ThinQ camera sensors Gaurav Suman via B4 Relay
2026-11-09 22:38 ` Gaurav Suman
2026-11-09 22:38 ` [PATCH 1/8] dt-bindings: media: Add qcom,sm8150-camss Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-09 22:56   ` sashiko-bot
2026-11-10  8:13   ` Krzysztof Kozlowski
2026-11-09 22:38 ` [PATCH 2/8] media: qcom: camss: Add SM8150 support Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-09 22:56   ` sashiko-bot
2026-11-10  0:00   ` Bryan O'Donoghue
2026-11-09 22:38 ` [PATCH 3/8] dt-bindings: media: i2c: Add Samsung S5K3M3 image sensor Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-09 22:43   ` sashiko-bot [this message]
2026-11-10  8:16   ` Krzysztof Kozlowski
2026-11-09 22:38 ` [PATCH 4/8] media: i2c: Add Samsung S5K3M3 image sensor driver Gaurav Suman
2026-11-09 22:38   ` Gaurav Suman via B4 Relay
2026-11-09 22:52   ` sashiko-bot
2026-11-10  0:04   ` Bryan O'Donoghue
2026-11-10  8:18   ` Krzysztof Kozlowski
2026-11-09 22:38 ` [PATCH 5/8] dt-bindings: media: i2c: Add Samsung S5KGD1 image sensor Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-10  8:18   ` Krzysztof Kozlowski
2026-11-09 22:38 ` [PATCH 6/8] media: i2c: Add Samsung S5KGD1 image sensor driver Gaurav Suman
2026-11-09 22:38   ` Gaurav Suman via B4 Relay
2026-11-09 22:54   ` sashiko-bot
2026-11-09 22:38 ` [PATCH 7/8] dt-bindings: media: i2c: Add ON Semiconductor LC898123F40 Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-10  8:20   ` Krzysztof Kozlowski
2026-11-09 22:38 ` [PATCH 8/8] media: i2c: Add ON Semiconductor LC898123F40 lens autofocus driver Gaurav Suman via B4 Relay
2026-11-09 22:38   ` Gaurav Suman
2026-11-09 22:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-205766@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gauravsuman007@gmail.com \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.