Re: [PATCH v4 4/9] drm/vc4: hdmi: Propagate -EDEADLK to the top level

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/vc4: hdmi: missing Fixes trailer for
  vc4_hdmi_handle_hotplug()
--

commit 6d4e22aadcba086750601443588ce618f73cc846
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

> drm/vc4: hdmi: Propagate -EDEADLK to the top level
>
> drm_connector_helper_funcs.detect_ctx() is expected to propagate
> -EDEADLK so that context owners, e.g. drm_helper_probe_detect_ctx(), can
> perform the required backoff and retry.
>
> vc4_hdmi_handle_hotplug() instead runs its own retry loop and calls
> drm_modeset_backoff() on an acquire context it does not own.  This drops
> all locks in the context, including connection_mutex held by the core.
>
> Drop the local retry logic and propagate -EDEADLK to the caller instead.
> This aligns VC4 with the expected detect_ctx() semantics.
>
> Acked-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

[Severity: Low]
Since this fixes the local retry loop and drm_modeset_backoff() call in
vc4_hdmi_handle_hotplug(), should this include a Fixes tag?

  Fixes: 479d4f0be423 ("drm/vc4: drop all currently held locks if deadlock happens")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-vc4-common-scramb-v4-0-eaa141a0da0f@collabora.com?part=4