Re: [PATCH v7 07/10] riscv: stacktrace: introduce stack-bound tracking helpers

[sashiko-bot@kernel.org]

> From: Wang Han <wanghan@linux.alibaba.com>
> 
> A reliable unwinder needs to validate that every frame record it reads
> is fully contained in a known kernel stack, and it needs to refuse to
> walk back into a stack it has already left. Add the building blocks
> for that:
> 
>   * struct stack_info / struct unwind_state in a new
>     asm/stacktrace/common.h, modelled on the arm64 reference
>     implementation.
>   * stackinfo_get_irq() / stackinfo_get_task() / stackinfo_get_overflow()
>     plus the corresponding on_*_stack() predicates in asm/stacktrace.h,
>     so callers can ask "is this object on stack X?" by stack kind
>     rather than open-coded address arithmetic.
>   * unwind_init_common(), unwind_find_stack() and
>     unwind_consume_stack() helpers that enforce the
>     forward-progress-only invariant required for reliability.
> 
> No existing user is wired up to these helpers in this commit; the
> unwinder switch comes in a follow-up. The header changes leave
> on_thread_stack() with the same semantics as before, just expressed in
> terms of the new helpers.
> 
> Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>
> Reviewed-by: Martin Kaiser <martin@kaiser.cx>
> Tested-by: Martin Kaiser <martin@kaiser.cx>
> Signed-off-by: Wang Han <wanghan@linux.alibaba.com>
> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110013750.36800-1-xueshuai@linux.alibaba.com?part=7