Re: [PATCH 6.12.y] mm/damon/core: move static variable last_nr_regions to damon_ctx

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] mm/damon: last_nr_regions placed in public section of struct
  damon_ctx
--

commit eb0ad0bdecede5a2fbbdad016dac644dd4b389f4
Author: SJ Park <sj@kernel.org>

mm/damon/core: move static variable last_nr_regions to damon_ctx

This commit moves the static last_nr_regions variable from
kdamond_split_regions() into struct damon_ctx so parallel kdamond threads
do not race on region split state.

Link: https://lore.kernel.org/20261025164808.152048-3-sj@kernel.org

> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 4688a10eca89b..dfd0295104d37 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -641,6 +641,11 @@ struct damon_ctx {
>  
>  	struct list_head adaptive_targets;
>  	struct list_head schemes;
> +	/*
> +	 * number of regions after last merge.  Read kdamond_split_regions()
> +	 * for more details.
> +	 */
> +	unsigned long last_nr_regions;
>  };
>  
>  static inline struct damon_region *damon_next_region(struct damon_region *r)

[Severity: Low]
Should last_nr_regions be placed inside the /* private: internal use only */
section of struct damon_ctx (or preceded by a /* private: */ marker)?

In this tree, the end of struct damon_ctx is after /* public: */, so adding
last_nr_regions here without a kernel-doc entry causes scripts/kernel-doc
(via Documentation/mm/damon/api.rst) to warn:

  Function parameter or struct member 'last_nr_regions' not described in 'damon_ctx'

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110022924.115699-1-sj@kernel.org?part=1