Re: [PATCH v6 1/4] usb: xhci: sideband: fix ring sg table for sub-page TRB segments

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usb: xhci: sideband: missing Fixes trailer in
  xhci_ring_to_sgtable() fix
--

commit daeb30414f41a889c527fcde183d2b47baf749d5
Author: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

> usb: xhci: sideband: fix ring sg table for sub-page TRB segments
>
> xhci_ring_to_sgtable() populated its sg_table via dma_get_sgtable()
> per segment and sg_alloc_table_from_pages(), both of which only
> operate at whole PAGE_SIZE granularity. Since TRB_SEGMENT_SIZE (4096)
> can be smaller than PAGE_SIZE, these helpers describe a full page for
> each ring segment on larger-PAGE_SIZE kernels (16K/64K), and cannot
> correctly represent segments that share the same physical page.
>
> Build the sg_table directly instead: allocate one sg entry per ring
> segment with sg_alloc_table(), and fill each entry explicitly with
> sg_set_page() using the segment's own page, TRB_SEGMENT_SIZE as the
> length, and offset_in_page() for the exact intra-page offset. Walk the
> table with for_each_sg() so this also works for chained sg tables.
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>

[Severity: Low]
Since this fixes xhci_ring_to_sgtable() on kernels with PAGE_SIZE larger
than TRB_SEGMENT_SIZE, should it include a Fixes tag?

  Fixes: de66754e9f80 ("xhci: sideband: add initial api to register a secondary interrupter entity")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-16k_offload_v1_b4-v6-0-858c6e0e007d@oss.qualcomm.com?part=1