From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 04/11] serial: 8250: share the RX trigger conversion helper
Date: Tue, 10 Nov 2026 03:16:48 +0000 [thread overview]
Message-ID: <sashiko-outbox-206100@kernel.org> (raw)
In-Reply-To: <20261109-submit-h616-uart-fifo-v1-v9-4-3f03961dae8a@gmail.com>
> Drivers can supply receive-trigger thresholds through the RX trigger
> callbacks without adding a legacy port type to uart_config[]. Extract the
> threshold search into serial8250_bytes_to_fcr() so those drivers can use
> the same conversion as the generic 8250 implementation.
>
> Keep the implementation in 8250_port.c and share it within 8250_base.
> Include the unsupported-table check and preserve the existing nearest-lower
> selection and highest-encoding fallback.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-submit-h616-uart-fifo-v1-v9-0-3f03961dae8a@gmail.com?part=4
next prev parent reply other threads:[~2026-11-10 3:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:12 [PATCH v9 00/11] serial: 8250_dw: share RX trigger setup and describe Allwinner UARTs James Hilliard
2026-11-10 3:12 ` [PATCH v9 01/11] serial: 8250_dw: allow port setup to report errors James Hilliard
2026-11-10 3:17 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 02/11] serial: 8250_dw: select port setup through platform data James Hilliard
2026-11-10 3:16 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 03/11] serial: 8250: widen RX trigger byte counts to 16 bits James Hilliard
2026-11-10 3:17 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 04/11] serial: 8250: share the RX trigger conversion helper James Hilliard
2026-11-10 3:16 ` sashiko-bot [this message]
2026-11-10 3:12 ` [PATCH v9 05/11] serial: 8250: expose RX trigger controls for custom callbacks James Hilliard
2026-11-10 3:23 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 06/11] serial: 8250_dw: derive RX trigger thresholds from the FIFO depth James Hilliard
2026-11-10 3:36 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 07/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner H616 James Hilliard
2026-11-10 3:16 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 08/11] serial: 8250_dw: configure the Allwinner H616 UART James Hilliard
2026-11-10 3:21 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 09/11] dt-bindings: serial: snps-dw-apb-uart: add Allwinner A523 James Hilliard
2026-11-10 3:18 ` sashiko-bot
2026-11-10 3:12 ` [PATCH v9 10/11] serial: 8250_dw: discover Allwinner A523 FIFO depths through FCC James Hilliard
2026-11-10 3:20 ` sashiko-bot
2026-11-10 3:13 ` [PATCH v9 11/11] serial: 8250_dw: configure RX trigger thresholds for Octeon James Hilliard
2026-11-10 3:23 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206100@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.