From: sashiko-bot@kernel.org
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] gpu: nova-core: factor out and expose Falcon::is_processor_suspended()
Date: Tue, 10 Nov 2026 03:40:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-206134@kernel.org> (raw)
In-Reply-To: <20261110033655.148487-3-jhubbard@nvidia.com>
> The r000 boot protocol requires the driver to wait for the GSP suspend
> bit after each load-and-execute event. The shutdown path already does
> this.
>
> The boot sequence will soon need this same functionality, so factor it
> out into a method, and put it in it's logical location as well, as a new
> method of Falcon<Gsp>.
>
> Also, use register!() for this, instead of manually masking off bit 31.
> As usual, that results in much more readable code.
>
> No functional changes.
>
> Co-developed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110033655.148487-1-jhubbard@nvidia.com?part=2
next prev parent reply other threads:[~2026-11-10 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:36 [PATCH 0/2] gpu: nova-core: add two prerequisites for the r000 GSP firmware John Hubbard
2026-11-10 3:36 ` [PATCH 1/2] rust: pci: add domain_nr() accessor John Hubbard
2026-11-10 3:48 ` sashiko-bot
2026-11-10 12:43 ` Danilo Krummrich
2026-11-11 19:07 ` John Hubbard
2026-11-10 3:36 ` [PATCH 2/2] gpu: nova-core: factor out and expose Falcon::is_processor_suspended() John Hubbard
2026-11-10 3:40 ` sashiko-bot [this message]
2026-11-11 4:20 ` Eliot Courtney
2026-11-11 11:45 ` (subset) [PATCH 0/2] gpu: nova-core: add two prerequisites for the r000 GSP firmware Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206134@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.