Re: [PATCH 1/3] drm/amd/display: Initialize FRL status polling work once at DM init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amd/display: Fixes trailer cites 5c9b8b27a883 instead of
  0e967e086e75
--

commit 3f93b63ddceded95cea3ea6ed4bbadf253534d70
Author: Eren Özen <erenozen@protonmail.com>

> drm/amd/display: Initialize FRL status polling work once at DM init
>
> hdmi_frl_status_polling_work is a single delayed work item shared by the
> whole display manager, but it is initialized from
> amdgpu_dm_connector_init_helper(), which runs once for every connector.
> That helper is also called at runtime from dm_dp_add_mst_connector()
> when a DisplayPort MST branch device is plugged in. If an HDMI FRL
> stream is active at that moment, the polling work is queued and
> re-arming itself every 200ms, and INIT_DELAYED_WORK() on it
> reinitializes the timer and work entry of a pending item, which can
> corrupt the timer and workqueue state.
>
> The work item belongs to the display manager, not to a connector, so
> initialize it, along with its polling delay, once in amdgpu_dm_init()
> next to the workqueue it runs on.
>
> Fixes: 5c9b8b27a883 ("drm/amd/display: Tie FRL support into amdgpu_dm")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Eren Özen <erenozen@protonmail.com>

[Severity: Low]
5c9b8b27a883 ("drm/amd/display: Tie FRL support into amdgpu_dm") originally
initialized hdmi_frl_status_polling_delay_ms and hdmi_frl_status_polling_work
once inside amdgpu_dm_init(), and 0e967e086e75 ("drm/amd/display: Extract
connector and encoder code to amdgpu_dm_connector") moved those two lines into
amdgpu_dm_connector_init_helper().  Should the Fixes: tag reference that
commit instead?

  Fixes: 0e967e086e75 ("drm/amd/display: Extract connector and encoder code to amdgpu_dm_connector")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-frl-polling-wq-teardown-v1-0-0ff028d5c35b@protonmail.com?part=1