From: sashiko-bot@kernel.org
To: zhaofeng2 <zhaofeng2@cmss.chinamobile.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: j721e: Fix OF node reference leak in j721e_enable_acspcie_refclk()
Date: Tue, 10 Nov 2026 07:16:19 +0000 [thread overview]
Message-ID: <sashiko-outbox-206470@kernel.org> (raw)
In-Reply-To: <20261110070944.996-3-zhaofeng2@cmss.chinamobile.com>
> From: Zhao Feng <zhaofeng2@cmss.chinamobile.com>
>
> j721e_enable_acspcie_refclk() resolves the "ti,syscon-acspcie-proxy-ctrl"
> phandle with of_parse_phandle_with_fixed_args(), which takes a
> reference on the resolved device node, but the reference is never
> dropped, so the device node is leaked. This is called from
> j721e_pcie_ctrl_init(), which j721e_pcie_resume_noirq() re-invokes
> on every resume, so the leak repeats on every suspend/resume cycle
> as well.
>
> Drop the reference with of_node_put() once the mask argument has been
> consumed.
>
> Fixes: 82c4be4168e2 ("PCI: j721e: Enable ACSPCIE Refclk if "ti,syscon-acspcie-proxy-ctrl" exists")
> Signed-off-by: Zhao Feng <zhaofeng2@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110070944.996-1-zhaofeng2@cmss.chinamobile.com?part=2
prev parent reply other threads:[~2026-11-10 7:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 7:09 [PATCH 0/2] PCI: j721e: fix OF node reference leaks zhaofeng2
2026-11-10 7:09 ` [PATCH 1/2] PCI: j721e: Fix OF node reference leak in j721e_pcie_ctrl_init() zhaofeng2
2026-11-10 7:19 ` sashiko-bot
2026-11-10 7:09 ` [PATCH 2/2] PCI: j721e: Fix OF node reference leak in j721e_enable_acspcie_refclk() zhaofeng2
2026-11-10 7:16 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206470@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhaofeng2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.