All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Qianghua Wang" <qianghua.wang@senarytech.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: sdw_utils: senary: handle a missing name_prefix
Date: Tue, 10 Nov 2026 07:44:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-206531@kernel.org> (raw)
In-Reply-To: <20261110073420.842175-1-qianghua.wang@senarytech.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: sdw_utils: senary: missing Fixes trailer for NULL
  name_prefix fix
--

commit 845de21a0dee73033616aab7b25b28f57952951d
Author: Qianghua Wang <qianghua.wang@senarytech.com>

> ASoC: sdw_utils: senary: handle a missing name_prefix
>
> asoc_sdw_senary_sdca_jack_rtd_init() passes component->name_prefix to
> strstr(). When codec_conf does not apply the prefix, name_prefix is
> NULL and card registration oopses.
>
> DAPM widgets then keep the bare names from the codec driver (HP, MIC2,
> SPK, DMIC). Keep the existing "sn624x ..." routes when name_prefix is
> set, and connect those bare widgets when it is missing. card->components
> still reports hs:sn624x-sdca and mic:sn624x-dmic.
>
> Signed-off-by: Qianghua Wang <qianghua.wang@senarytech.com>

[Severity: Low]
Since this fixes a NULL pointer dereference in the SN624x helpers, should
the commit message include:

  Fixes: 77272ecd96d7 ("ASoC: sdw_utils: add Senary SN624x helpers and codec_info")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110073420.842175-1-qianghua.wang@senarytech.com?part=1

  reply	other threads:[~2026-11-10  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  7:34 [PATCH] ASoC: sdw_utils: senary: handle a missing name_prefix Qianghua Wang
2026-11-10  7:44 ` sashiko-bot [this message]
2026-11-10  8:05 ` [PATCH v2] " Qianghua Wang
2026-11-10 14:45   ` Liao, Bard
2026-11-11  6:36     ` reply " qianghua.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-206531@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=qianghua.wang@senarytech.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.