From: sashiko-bot@kernel.org
To: "Gu Bin" <gubin@cmss.chinamobile.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: imx: return error when clk_per fails in imx_uart_poll_init()
Date: Tue, 10 Nov 2026 11:01:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-206910@kernel.org> (raw)
In-Reply-To: <20261110105456.1563-1-gubin@cmss.chinamobile.com>
> In imx_uart_poll_init(), when clk_prepare_enable(sport->clk_per) fails
> the error branch only disables the previously enabled clk_ipg and then
> falls through: the function keeps programming the UART (imx_uart_setup_ufcr
> and the register writes below) with both clocks disabled and eventually
> returns 0, reporting success for a port that never came up.
>
> The sibling imx_uart_startup() handles the same situation by returning
> the error after the rollback.
>
> Return the error after rolling back clk_ipg, matching
> imx_uart_startup().
>
> Fixes: 6b8bdad96164 ("serial: imx: add imx_poll_init()")
> Signed-off-by: Gu Bin <gubin@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261110105456.1563-1-gubin@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-10 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 10:54 [PATCH] tty: serial: imx: return error when clk_per fails in imx_uart_poll_init() Gu Bin
2026-11-10 11:01 ` sashiko-bot [this message]
2026-11-11 9:21 ` Jiri Slaby
2026-11-11 9:37 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206910@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gubin@cmss.chinamobile.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.